Improved safety atop.daily#379
Open
GermanAizek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons create this PR changes
Substitution of variables without quotation marks
In shell scripts, $PIDFILE and $LOGPATH are sometimes used without quotes, which is dangerous for paths with spaces or special characters
Executing external commands with substitution
The use of ps -p
'cat $PIDFILE'and similar constructions (kill'cat $PIDFILE') is dangerous if there is no verification of the contents of the PID file (for example, if the file is tampered with by an attacker)Without checking the expandable path, it potentially allows you to delete files outside the destination area if variables are substituted
Before using the contents of the PIDFILE, make sure that it contains only numbers.
Instead of rm {} use -- and quoting