Skip to content

Fix edit-track download action for legacy non-downloadable tracks #13987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cursor wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix edit-track download action for legacy non-downloadable tracks #13987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/mobile/src/screens/edit-track-screen/EditTrackForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,15 @@ export const EditTrackForm = (props: EditTrackFormProps) => {
return
}

const canDownloadOriginal = Boolean(
initialValues.is_original_available && initialValues.orig_file_cid
)

openWaitForDownload({
trackIds: [initialValues.track_id],
quality: DownloadQuality.ORIGINAL
quality: canDownloadOriginal
? DownloadQuality.ORIGINAL
: DownloadQuality.MP3
})

// Track Download event
Expand All @@ -216,7 +222,12 @@ export const EditTrackForm = (props: EditTrackFormProps) => {
trackId: initialValues.track_id
})
)
}, [openWaitForDownload, initialValues.track_id])
}, [
openWaitForDownload,
initialValues.track_id,
initialValues.is_original_available,
initialValues.orig_file_cid
])

const handlePressBack = useCallback(() => {
if (!dirty) {
Expand Down
16 changes: 14 additions & 2 deletions packages/web/src/components/edit-track/EditTrackForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,16 @@ const TrackEditForm = (
return
}

const canDownloadOriginal = Boolean(
initialTrackValues.is_original_available &&
initialTrackValues.orig_file_cid
)

openWaitforDownload({
trackIds: [initialTrackValues.track_id],
quality: DownloadQuality.ORIGINAL
quality: canDownloadOriginal
? DownloadQuality.ORIGINAL
: DownloadQuality.MP3
})

// Track Download event
Expand All @@ -343,7 +350,12 @@ const TrackEditForm = (
trackId: initialTrackValues.track_id
})
)
}, [openWaitforDownload, initialTrackValues.track_id])
}, [
openWaitforDownload,
initialTrackValues.track_id,
initialTrackValues.is_original_available,
initialTrackValues.orig_file_cid
])

return (
<Form id={formId}>
Expand Down
Loading