Skip to content

Fix partial album/playlist uploads on per-track publish failures #14028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cursor wants to merge 1 commit into from
Closed

Fix partial album/playlist uploads on per-track publish failures #14028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions packages/common/src/api/tan-query/upload/usePublishCollection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,15 @@ const getPublishCollectionOptions = (context: PublishCollectionContext) =>
params.tracks
)

const failedTracks = publishedTracks.filter(
(track) => track.error || !track.trackId
)
if (failedTracks.length > 0) {
throw new Error(
`Failed to publish ${failedTracks.length} of ${params.tracks.length} collection tracks`
)
}

// For collection artwork, use the existing flow (not TUS) to keep things simple for now.
const { artwork } = params.collectionMetadata
const artworkBlob =
Expand All @@ -103,13 +112,11 @@ const getPublishCollectionOptions = (context: PublishCollectionContext) =>
const metadata = albumMetadataForCreateWithSDK(
params.collectionMetadata
)
metadata.playlistContents = publishedTracks
.filter((t) => !!t.trackId)
.map((t) => ({
timestamp: Math.round(Date.now() / 1000),
trackId: t.trackId!,
metadataTimestamp: Math.round(Date.now() / 1000)
}))
metadata.playlistContents = publishedTracks.map((track) => ({
timestamp: Math.round(Date.now() / 1000),
trackId: track.trackId!,
metadataTimestamp: Math.round(Date.now() / 1000)
}))
return await sdk.albums.createAlbum({
userId: Id.parse(userId),
imageFile: coverArtFile,
Expand All @@ -119,13 +126,11 @@ const getPublishCollectionOptions = (context: PublishCollectionContext) =>
const metadata = playlistMetadataForCreateWithSDK(
params.collectionMetadata
)
metadata.playlistContents = publishedTracks
.filter((t) => !!t.trackId)
.map((t) => ({
timestamp: Math.round(Date.now() / 1000),
trackId: t.trackId!,
metadataTimestamp: Math.round(Date.now() / 1000)
}))
metadata.playlistContents = publishedTracks.map((track) => ({
timestamp: Math.round(Date.now() / 1000),
trackId: track.trackId!,
metadataTimestamp: Math.round(Date.now() / 1000)
}))
return await sdk.playlists.createPlaylist({
userId: Id.parse(userId),
imageFile: coverArtFile,
Expand Down
Loading