Skip to content

AISAST-10685-XXE via entity substitution enabled by noent … #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunilnain7 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

AISAST-10685-XXE via entity substitution enabled by noent … #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/authorize_net/xml_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ def initialize(raw_response, transaction)
unless connection_failure?
begin
xml = Nokogiri::XML(@raw_response.body) do |config|
# confirm noent is the right flag
config.recover.noent.nonet
# Security: Do NOT use .noent - it enables entity substitution which allows XXE attacks.
# Predefined XML entities (&, <, etc.) are decoded by default without .noent.
config.recover.nonet
end
@root = xml.children[0]
@result_code = node_content_unless_nil(@root.at_css('messages resultCode'))
Expand Down