fix: ensure_path checks rc file, not runtime PATH#72
Merged
George-iam merged 2 commits intomainfrom Mar 24, 2026
Merged
Conversation
When the user manually exports PATH before running install.sh via pipe, the subprocess inherits that PATH. The old runtime check (case ":$PATH:") would return early without modifying .zshrc, leaving future terminal sessions without axme in PATH. Now we only check the rc file for duplicates, which is the correct persistent indicator.
- ensure_path now prints "source ~/.zshrc" hint after modifying rc file - README install block includes source command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
case ":$PATH:") fromensure_path()in install.sh.zshrc/.bashrc/etc.) for duplicates before adding PATH entrycurl ... | shinherits a temporaryexport PATHfrom the parent shell, causingensure_pathto skip rc file modification — leaving future terminal sessions withoutaxmein PATHTest plan
export PATH="$HOME/.local/bin:$PATH"thencurl -fsSL .../install.sh | sh— should still add to.zshrc.zshrcand print "Adding to PATH"