Skip to content

[WIP]fix: retry block broadcast and proposal#19870

Closed
deffrian wants to merge 1 commit intonextfrom
nikita/retry-broadcast
Closed

[WIP]fix: retry block broadcast and proposal#19870
deffrian wants to merge 1 commit intonextfrom
nikita/retry-broadcast

Conversation

@deffrian
Copy link
Copy Markdown
Collaborator

Ref: A-453

@deffrian deffrian force-pushed the nikita/retry-broadcast branch from c151e10 to 425817c Compare January 23, 2026 11:23
@deffrian deffrian force-pushed the nikita/retry-broadcast branch from 425817c to 54c6101 Compare January 23, 2026 12:12
@AztecBot
Copy link
Copy Markdown
Collaborator

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/d97198198f6be2f5�d97198198f6be2f58;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/rediscovery.test.ts (178s) (code: 1) group:e2e-p2p-epoch-flakes (\033Nikita Meshcheriakov\033: fix: retry block broadcast and proposal)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/f41fda0730f2031b�f41fda0730f2031b8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_l1_reorgs.test.ts (386s) (code: 1) group:e2e-p2p-epoch-flakes (\033Nikita Meshcheriakov\033: fix: retry block broadcast and proposal)

Copy link
Copy Markdown
Contributor

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think retrying some operations during block building is good if we think they could fail, but I don't think this addresses the main issue, which is an unhandled exception during building a block. Still, before we jump into implementing, we need to make a good pass at understanding what steps can fail, define what we want to roll back to, and then implement. For instance, what do we want to do if building the block fails? Or if the sequencer publisher fails?

Let's talk over standup about this!

this.log.error(`Failed to sync proposed block ${block.number} to archiver`, { blockNumber: block.number, err });
});

usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString()));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, good catch! Can you push this in a separate PR?

@spalladino
Copy link
Copy Markdown
Contributor

Also, implementation wise, it's better if you can leverage one of the retry or retryUntil functions in foundation, so we don't need so much code for the retries.

@deffrian deffrian closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants