[WIP]fix: retry block broadcast and proposal#19870
Conversation
c151e10 to
425817c
Compare
425817c to
54c6101
Compare
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
spalladino
left a comment
There was a problem hiding this comment.
I think retrying some operations during block building is good if we think they could fail, but I don't think this addresses the main issue, which is an unhandled exception during building a block. Still, before we jump into implementing, we need to make a good pass at understanding what steps can fail, define what we want to roll back to, and then implement. For instance, what do we want to do if building the block fails? Or if the sequencer publisher fails?
Let's talk over standup about this!
| this.log.error(`Failed to sync proposed block ${block.number} to archiver`, { blockNumber: block.number, err }); | ||
| }); | ||
|
|
||
| usedTxs.forEach(tx => txHashesAlreadyIncluded.add(tx.txHash.toString())); |
There was a problem hiding this comment.
Hah, good catch! Can you push this in a separate PR?
|
Also, implementation wise, it's better if you can leverage one of the |
Ref: A-453