chore!: update domain separators #19905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeilaWang
requested review from
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
LeilaWang
force-pushed
the
lw/update_domain_separators
branch
2 times, most recently
from
24cad60 to
8d3b9ea
Compare
LeilaWang
force-pushed
the
lw/update_domain_separators
branch
5 times, most recently
from
7689d3e to
614aec9
Compare
LeilaWang
requested review from
iAmMichaelConnor
and removed request for
LHerskind and
just-mitch
IlyasRidhuan
approved these changes
Jan 27, 2026
Contributor
IlyasRidhuan
left a comment
IlyasRidhuan
left a comment
There was a problem hiding this comment.
Looks good from the AVM side
iAmMichaelConnor
approved these changes
Jan 28, 2026
Contributor
iAmMichaelConnor
left a comment
iAmMichaelConnor
left a comment
There was a problem hiding this comment.
Approved! I wrote some pedantic comments that would change the domain separator string, but it looks like it would take forever to make such changes, so it's likely not worth your time.
noir-projects/noir-protocol-circuits/crates/types/src/domain_separators.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/types/src/domain_separators.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-protocol-circuits/crates/types/src/domain_separators.nr
Outdated
Show resolved
Hide resolved
| assert(DOM_SEP__TSK_M == 51, "Unexpected domain separator"); | ||
| // assert(DOM_SEP__TSK_M == derive_dom_sep("az_tsk_m"), "Unexpected domain separator"); | ||
| unconstrained fn tsk_m_matches_derived() { | ||
| assert_eq(DOM_SEP__TSK_M, derive_dom_sep("az_tsk_m"), "Unexpected domain separator"); |
Contributor
There was a problem hiding this comment.
We might repurpose this to something else, but I guess until we know the name, we can't replace this name.
| unconstrained fn contract_address_v1_matches_derived() { | ||
| assert_eq( | ||
| DOM_SEP__CONTRACT_ADDRESS_V1, | ||
| derive_dom_sep("az_contract_address_v1"), |
Contributor
There was a problem hiding this comment.
Each version of the Aztec rollup, we'll need to change* this domain separator with the new rollup version. Will the rollups be named v1, v2, ...?
* Or more likely add another domain separator and pass it as a param to address derivations, so that people can still compute old addresses for things like migration proofs.
| // The following value was generated by `public_keys.test.ts`. | ||
| let expected_public_keys_hash = | ||
| 0x0fecd9a32db731fec1fded1b9ff957a1625c069245a3613a2538bd527068b0ad; | ||
| 0x029d92319623fe2e5804a64b35d13e1c4881045371c41f36329b44dfc237d232; |
Contributor
There was a problem hiding this comment.
Omg this must have taken ages
LeilaWang
force-pushed
the
lw/update_domain_separators
branch
2 times, most recently
from
8fd4a5e to
734c4b1
Compare
LeilaWang
force-pushed
the
lw/update_domain_separators
branch
from
734c4b1 to
396231f
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poseidon2_hash('az_name_of_separator') as u32DOM_SEP__PUBLIC_LEAF_INDEXtoDOM_SEP__PUBLIC_LEAF_SLOTDOM_SEP__BLOCK_HASHtoDOM_SEP__BLOCK_HEADER_HASHDOM_SEP__OUTER_NULLIFIERtoDOM_SEP__SILOED_NULLIFIERDOM_SEP__FUNCTION_LEAFtoDOM_SEP__PRIVATE_FUNCTION_LEAFDOM_SEP__CONSTRUCTORtoDOM_SEP__INITIALIZERDOM_SEP__PUBLIC_STORAGE_MAP_SLOTDOM_SEP__PRIVATE_LOG_FIRST_FIELD