fix: resolve path issues in KIND test scripts #19911
Open
+1,560
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
changed the title
ludamad
force-pushed
the
ad/misc-kind-fixups
branch
3 times, most recently
from
5417d64 to
b045a8a
Compare
…loyment - Fix path resolution bug in test_kind.sh that caused CI failure - Add KIND network test support with ci-network-kind label - Add retry logic for L1 deployments and remove geth txfeecap - Add RPC body size CLI options and KIND teardown script - Add dedicated 64 CPU instance for upgrade rollup version test - Deploy RegisterNewRollupVersionPayload from upgrade script - Remove unused network-status.ts file
ludamad
force-pushed
the
ad/misc-kind-fixups
branch
from
b045a8a to
96d7e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spartan/scripts/test_kind.shthat caused CI failurenetwork-status.tsfileThe
test_kind.shscript was failing because it sourcedci3/sourcebefore calculating relative paths. Theci3/sourcescript changes the working directory, which broke subsequent path calculations. Fixed by resolving paths before sourcing.