Skip to content

Conversation

@vezenovm
Copy link
Contributor

If I want to test a patch in the Noir submodule against CI by altering noir/noir-repo directly rather than needing a new temporary tag it is currently not possible.

When aztec-up fetchs the versions the noir_version expects an exact match for the tag.

This prevents being able to directly modify the submodule as no tag exists. I ran into this issue in #19871 where CI would fail with fatal: no tag exactly matches '515b2702975fd85069fae48ddd0d90a56cd65628' at aztec-up/bootstrap.sh. This does not affect release builds as those are also protected in the Noir build.

@TomAFrench TomAFrench added this pull request to the merge queue Jan 27, 2026
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 27, 2026

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/8080a316a3779366�8080a316a37793668;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/valid_epoch_pruned_slash.test.ts (396s) (code: 1) group:e2e-p2p-epoch-flakes (\033Tom French\033: fix(ci): Do not use --exact-match when setting Noir versions for aztec-up bootstrap (#19945))

Merged via the queue into next with commit 89e9741 Jan 27, 2026
16 checks passed
@TomAFrench TomAFrench deleted the mv/no-exact-match-noir-subrepo branch January 27, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants