fix: skip GitHub release creation for nightly and devnet tags#21732
Draft
AztecBot wants to merge 2 commits intomerge-train/spartanfrom
Draft
fix: skip GitHub release creation for nightly and devnet tags#21732AztecBot wants to merge 2 commits intomerge-train/spartanfrom
AztecBot wants to merge 2 commits intomerge-train/spartanfrom
Conversation
Nightly and devnet tags only need a git tag, not a full GitHub release. This keeps the releases page clean while still publishing Docker images and npm packages via per-project release steps. - bootstrap.sh: release_github() returns early for nightly/devnet dist tags - barretenberg/cpp/bootstrap.sh: skip binary upload when no release exists
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip GitHub release creation only for nightly and private tags. Devnet, stable, and RC tags continue to create GitHub releases.
v*-nightly.*): git tag only, no GitHub releasev*-private.*): git tag only, no GitHub releasev*-devnet.*): full GitHub release (for the release page)All tag types continue to publish Docker images and npm packages as before.
Changes
bootstrap.sh: Updatedrelease_githubto skipnightlyandprivate(notdevnet)barretenberg/cpp/bootstrap.sh: Updated comment to reflect new skip list