feat(security): acir vs circuit components comparison tool#21737
Open
feat(security): acir vs circuit components comparison tool#21737
Conversation
defkit
commented
Mar 18, 2026
| std::unordered_map<uint32_t, size_t> get_witness_component_map() const; | ||
|
|
||
| private: | ||
| std::unordered_map<uint32_t, std::unordered_set<uint32_t>> adjacency_lists_; |
Contributor
Author
There was a problem hiding this comment.
opus suggested using union-find with dfs to save time and memory for larger circuits.
I'm not sure about this -- it still seems more expensive to construct the circuit
Will migrate to union-find if we decide to use this check in our main workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Build a graph on ACIR constraints' witnesses, build a circuit on this constraints, build a graph on the circuit
Check that: