Open
Conversation
## Summary - Ships `@aztec/bb.js` native binaries as separate per-platform packages (`@aztec/bb.js-linux-x64`, `@aztec/bb.js-linux-arm64`, `@aztec/bb.js-darwin-x64`, `@aztec/bb.js-darwin-arm64`) using the `optionalDependencies` pattern (same as esbuild, swc, etc.) - The wrapper `@aztec/bb.js` drops from ~170MB to ~17MB (JS + WASM only); npm/yarn/pnpm only download the matching platform's binaries - Platform detection in `platform.ts` resolves binaries from the arch package first, falls back to local `build/` for dev - Release pipeline and aztec-up Verdaccio setup updated to publish arch packages before the wrapper ## Test plan - [ ] Verify `npm pack` in `barretenberg/ts/` excludes `build/` directory - [ ] Verify `prepare_arch_packages.sh` generates correct package dirs with binaries - [ ] Verify `findBbBinary()` resolves from both arch package and `build/` fallback - [ ] Verify aztec-up Verdaccio tests install the correct arch package - [ ] Verify WASM fallback still works when no arch package is installed
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: split bb.js into arch-specific npm packages (#21700)
END_COMMIT_OVERRIDE