feat(aztec-nr): add initialization check to utility functions#21751
Open
nchamo wants to merge 5 commits intomerge-train/fairiesfrom
Open
feat(aztec-nr): add initialization check to utility functions#21751nchamo wants to merge 5 commits intomerge-train/fairiesfrom
nchamo wants to merge 5 commits intomerge-train/fairiesfrom
Conversation
nchamo
added
the
ci-no-fail-fast
nchamo
commented
Mar 18, 2026
|
|
||
| const notes: Note[] = [...Array(5).fill(buildNote(1n)), ...Array(2).fill(buildNote(2n))]; | ||
|
|
||
| const instanceFields = { |
Contributor
Author
There was a problem hiding this comment.
Since the utility assertion now uses get_contract_instance, which checks:
(instance.to_address() == address)
we can't use a random address anymore, so we use computeContractAddressFromInstance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes F-352