fix: avoid mutating caller's array via splice in snapshot sync (A-718)#21759
Open
PhilWindle wants to merge 1 commit intomerge-train/spartanfrom
Open
Conversation
PhilWindle
force-pushed
the
phil/a-718-audit-38-snapshot-sync-mutates-source-ids-array-via-splice
branch
from
e58872c to
186eee0
Compare
Use chunk + asyncPool to replace splice-based batching in BrokerCircuitProverFacade. Both getAllCompletedJobs and job retrieval now use non-mutating patterns with bounded concurrency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PhilWindle
force-pushed
the
phil/a-718-audit-38-snapshot-sync-mutates-source-ids-array-via-splice
branch
from
186eee0 to
8a5ca2b
Compare
alexghr
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
splice(0, N)with index-basedslice(i, i+N)inBrokerCircuitProverFacadeto avoid mutating the caller'sidsarray during snapshot sync batching.Fixes A-718
Test plan
splice(0, N)with non-mutatingslice(i, i+N)in a for-loop🤖 Generated with Claude Code