Conversation
Getting rid of the tyranny of the `Account` entrypoint, and the terrible sentinel value of `AztecAddress.ZERO` in the `from` parameter. Now, when a tx is specified as being sent `from: NO_FROM`, the wallet completely bypasses the account contract. It doesn't even use the `MulticallEntrypoint` contract, it'll just execute a single call using `DefaultEntrypoint`. Since we can do wrapping at the app level, this means ANYTHING goes. Want to wrap 10 calls on a special sauce multicall? Go ahead. App-sponsored FPC with custom logic that must be the first on the chain? Knock yourself out! Even better news: this is thoroughly tested in our codebase thanks to account contract self-deployments. They're a great example of "I don't want to use an account contract as entrypoint" flow. As an extra side effect, this completely deshrines the `MulticallEntrypoint` protocol contract from the wallet (we only have the convenience now of it being already registered in every single wallet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
refactor: revert remove assert_bounded_vec_trimmed (#21758)
END_COMMIT_OVERRIDE