Merged
Conversation
Mostly docs update for keccak.
AztecBot
requested review from
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Linear issue: [AVM-70](https://linear.app/aztec-labs/issue/AVM-70/calldata) --------- Co-authored-by: Miranda Wood <miranda@aztecprotocol.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Comment mentions wrong op
It's not a deep copy! A shallow copy or more accurately a fork.
jeanmon
approved these changes
Mar 20, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Adds the standard multi-row constraint to prevent valid computation from being maliciously terminated midway. Note there there is no vulnerability that this was fixing. `[WRITE_TO_SLICE]` is a permutation requiring `round == 24` so a malicious prover could not invalidly terminate the keccak computation. This is just to standardise multi-row constraints.
Removes 29 columns and subrelations by optimising the way we constrain bitwise rotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(avm): keccak pre-audit (#21486)
fix(avm)!: calldata - internal audit (#21380)
chore: fix alu comment (#21804)
chore: misnamed copy function in public db (#21810)
fix(avm)!: add std multi-row computation constraint (#21718)
fix(avm): fuzzer compilation issue related to calldata (#21838)
fix(avm)!: reduce keccakf cols (#21641)
END_COMMIT_OVERRIDE