ci: selectable branches + tag-collision suffix for nightly-release-tag#23986
Open
AztecBot wants to merge 1 commit into
Open
ci: selectable branches + tag-collision suffix for nightly-release-tag#23986AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
alexghr
approved these changes
Jun 11, 2026
7e543df to
303f1e3
Compare
## What Reworks `.github/workflows/nightly-release-tag.yml` to address two requests: ### 1. Manual runs can target a subset of branches `workflow_dispatch` now exposes three boolean inputs — `next`, `v5-next`, `v4-next` (all default `false`) — so a manual run tags only the branches you check. A new `configure` job builds the matrix: - **Scheduled run** → tags **all** candidate branches (unchanged behaviour: `next` + `v5-next` on both public and private, plus `v4-next` on the public repo only). - **Manual run** → tags only the selected branches. Selecting nothing produces an empty matrix and the tag job is skipped. Repo gating from the old separate jobs is preserved: `next`/`v5-next` run on `aztec-packages` and `aztec-packages-private`; `v4-next` only on `aztec-packages`. Other repos (forks) produce an empty matrix. ### 2. Collision-safe tag names Before tagging, the workflow checks the remote (`git ls-remote --tags origin`). If the computed `vX.Y.Z-nightly.YYYYMMDD` tag already exists, it appends `-1`, `-2`, … until it finds an unused name. This makes re-running a day's nightly (e.g. a manual re-tag) safe instead of failing on the existing tag. ## Notes - The two previous jobs (`nightly-release-tag` matrix + `nightly-release-tag-v4-next`) are consolidated into one matrix driven by the `configure` output, eliminating the duplicated tag script. - Input names with hyphens are read via `inputs['v5-next']` and passed through `env:` to avoid expression parsing issues and shell injection. --- *Created by [claudebox](https://claudebox.work/v2/sessions/ab9e531e21765a80) · group: `slackbot`*
303f1e3 to
6e6c93f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reworks
.github/workflows/nightly-release-tag.ymlto address two requests:1. Manual runs can target a subset of branches
workflow_dispatchnow exposes three boolean inputs —next,v5-next,v4-next(all defaultfalse) — so a manual run tags only the branches you check. A newconfigurejob builds the matrix:next+v5-nexton both public and private, plusv4-nexton the public repo only).Repo gating from the old separate jobs is preserved:
next/v5-nextrun onaztec-packagesandaztec-packages-private;v4-nextonly onaztec-packages. Other repos (forks) produce an empty matrix.2. Collision-safe tag names
Before tagging, the workflow checks the remote (
git ls-remote --tags origin). If the computedvX.Y.Z-nightly.YYYYMMDDtag already exists, it appends-1,-2, … until it finds an unused name. This makes re-running a day's nightly (e.g. a manual re-tag) safe instead of failing on the existing tag.Notes
nightly-release-tagmatrix +nightly-release-tag-v4-next) are consolidated into one matrix driven by theconfigureoutput, eliminating the duplicated tag script.inputs['v5-next']and passed throughenv:to avoid expression parsing issues and shell injection.Created by claudebox · group:
slackbot