chore(ci): public nightlies skip scenario tests and the next tag (backport #23984)#24009
Draft
AztecBot wants to merge 2 commits into
Draft
chore(ci): public nightlies skip scenario tests and the next tag (backport #23984)#24009AztecBot wants to merge 2 commits into
AztecBot wants to merge 2 commits into
Conversation
) Two changes scoped to the **public** repo (`AztecProtocol/aztec-packages`) nightly flow, plus a follow-up tightening of the scenario-test trigger. Private tagging is unchanged. `ci3.yml`'s `ci-network-scenario` job fired on any current nightly tag in both repos. Private produces both a `next` (v6) and a `v5-next` (v5) nightly tag, so simply gating to the private repo still ran scenarios against the v6 nightly. The nightly-triggered path is now gated to **private repo + a `v5.` nightly tag**: ```yaml ( needs.validate-nightly-tag.outputs.is_current == 'true' && github.repository == 'AztecProtocol/aztec-packages-private' && startsWith(github.ref_name, 'v5.') ) || contains(github.event.pull_request.labels.*.name, 'ci-network-scenario') ``` `v5-next` is at `5.x.x` (tag `v5.x.x-nightly.*`) and `next` is at `6.x.x` (tag `v6.x.x-nightly.*`), so `startsWith(github.ref_name, 'v5.')` selects the v5-next nightly only. The manual PR-label path (`ci-network-scenario`) is preserved for ad-hoc dev runs. `nightly-release-tag.yml`'s matrix tagged `[next, v5-next]` in both repos. The branch list is now repo-dependent: private keeps `[next, v5-next]`, public tags only `v5-next` (and `v4-next` via its existing dedicated job). Net result: **public tags `v4-next` + `v5-next` only**, private is untouched. Nightly network scenario tests should run only against the private v5-next nightly, and public should not produce a `next` nightly tag.
AztecBot
added
ci-draft
The private repo's nightly-release-tag matrix already tags v5-next, so the v5-next branch's own workflow produced a duplicate nightly tag. Tag from a single place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #23984 to
v5-next(via thebackport-to-v5-next-stagingstaging branch), plus removal of the now-duplicate v5-next nightly tag workflow.Changes
1.
ci3.yml— gateci-network-scenarioto the private v5-next nightly (clean merge):The nightly-triggered
ci-network-scenariojob now requires the private repo and av5.nightly tag, so it no longer fires against the v6 (next) nightly. Theci-network-scenarioPR-label path is preserved.2. Remove
nightly-release-tag.ymlon v5-next — tag from a single place:After #23984, the private repo's
nightly-release-tagmatrix tags bothnextandv5-next, so the v5-next branch's own nightly-tag workflow produced a duplicate v5-next nightly tag. Removed it so all nightly tagging happens in one place (the private repo matrix).Conflict resolution
PR #23984's
nightly-release-tag.ymlchange conflicted because v5-next's copy of that workflow had nobranch: [next, v5-next]matrix. Rather than adapt the matrix rewrite, the whole workflow is removed on v5-next (see change 2), which is the cleaner outcome.