TrendMicro V1 Data Connector - add id config, update version and build file#14533
Open
V1ManagedServices wants to merge 3 commits into
Open
TrendMicro V1 Data Connector - add id config, update version and build file#14533V1ManagedServices wants to merge 3 commits into
V1ManagedServices wants to merge 3 commits into
Conversation
Contributor
Author
|
Invocation logs, 
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Trend Micro Vision One data connector to support a new id site and bumps the connector version to 1.2.9.
Changes:
- Add
idto the supported site/region list in the ARM template. - Add the
idAPI host mapping to shared configuration. - Bump version from
1.2.8to1.2.9across connector files.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Solutions/Trend Micro Vision One/Data Connectors/azuredeploy_TrendMicroVisionOne_API_FunctionApp.json | Adds id to the allowed site parameter values. |
| Solutions/Trend Micro Vision One/Data Connectors/AzureFunctionTrendMicroXDR/timer_trigger_oat/init.py | Updates the version comment to 1.2.9. |
| Solutions/Trend Micro Vision One/Data Connectors/AzureFunctionTrendMicroXDR/timer_trigger/init.py | Updates the version comment to 1.2.9. |
| Solutions/Trend Micro Vision One/Data Connectors/AzureFunctionTrendMicroXDR/shared_code/configurations.py | Updates VERSION constant and adds id host URL mapping. |
| 'ca': 'https://api.ca.xdr.trendmicro.com', | ||
| 'za': 'https://api.za.xdr.trendmicro.com', | ||
| 'za': 'https://api.za.xdr.trendmicro.com', | ||
| 'id': 'https://api.id.xdr.trendmicro.com', |
Contributor
Author
There was a problem hiding this comment.
We have fixed this trailing whitespace issue. Thanks!
| @@ -1,4 +1,4 @@ | |||
| # ver: 1.2.8 | |||
| # ver: 1.2.9 | |||
| @@ -1,4 +1,4 @@ | |||
| # ver: 1.2.8 | |||
| # ver: 1.2.9 | |||
| @@ -1,4 +1,4 @@ | |||
| # ver: 1.2.8 | |||
| # ver: 1.2.9 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: