Open
Conversation
rlundeen2
reviewed
Mar 7, 2026
| def _check_ffmpeg_installed() -> bool: | ||
| """ | ||
| Check if ffmpeg is installed and available on PATH. | ||
|
|
Contributor
There was a problem hiding this comment.
It's okay to check this first, but likely not installed. @romanlutz lmk what you think, but imo we should use something like PyAV as an "all" dependency. It's relatively big, but we'll likely need a lot of audio/video editing and that seems like a good approach.
Contributor
There was a problem hiding this comment.
I agree. I suspect consumers may be less excited but having a million classes with a check on whether or not av is installed is silly. I imagine we'll have A LOT of converters with this over time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing pydub as a dependency. This was only used in our audio_transcript_scorer to extract audio from a video file.
Tests and Documentation
Reran unit tests and notebooks