MAINT Fix integration test import errors and runtime issues#1448
Open
romanlutz wants to merge 3 commits intoAzure:mainfrom
Open
MAINT Fix integration test import errors and runtime issues#1448romanlutz wants to merge 3 commits intoAzure:mainfrom
romanlutz wants to merge 3 commits intoAzure:mainfrom
Conversation
- Replace removed AttackIdentifier with ComponentIdentifier in integration mocks - Replace removed ScorerIdentifier with ComponentIdentifier in azure sql memory test - Guard rpyc import in hitl_gradio test to skip when module is unavailable - Use contextlib.suppress for cv2.destroyAllWindows() on headless OpenCV builds Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace plain dict attack_identifier with ComponentIdentifier in test_get_attack_results_by_harm_categories and test_get_attack_results_by_labels. AttackResultEntry.__init__ calls .to_dict() on attack_identifier which fails on plain dicts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several integration test files fail to collect or run due to code issues introduced when AttackIdentifier and ScorerIdentifier were consolidated into ComponentIdentifier:
dict for attack_identifier, but AttackResultEntry.init calls .to_dict() on it
Changes
tests/integration/mocks.py
tests/integration/memory/test_azure_sql_memory_integration.py
tests/integration/score/test_hitl_gradio_integration.py
pyrit/prompt_converter/add_image_to_video_converter.py