Compact document#5167
Conversation
| for (let i = 0; i < wrapped.length; i++) { | ||
| if (wrapped[i].includes("@") || wrapped[i].includes("*/")) { | ||
| if (wrapped[i].includes("@")) { | ||
| wrapped[i] = wrapped[i].replace(/@/g, "\\@"); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
There was a problem hiding this comment.
I don't think that is what the codeql is warning you about. I think it tells you that you won't escape this correctly
\@
becomes
\\@
but I think for how doc comments are parsed its a false positive.
you might also be able to replace to .replaceAll("@", "\\@") instead of using regex and it might not flag
|
Hi @@pshao25. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @@pshao25. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
@doc#5165