Conversation
jepetty
requested review from
Greedygre,
Juliehzl and
howang-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp job create | cmd containerapp job create update parameter parallelism: added property default=1 |
||
| containerapp job create | cmd containerapp job create update parameter replica_completion_count: added property default=1 |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where creating a container app job without specifying --parallelism and --replica-completion-count parameters would fail due to these values defaulting to 0, which is not accepted by the control plane. The fix changes the default values to 1, which aligns with the API documentation and expected behavior.
Changes:
- Updated default values for
parallelismandreplicaCompletionCountfrom 0 to 1 for manual and schedule trigger types in the job creation logic - Added a comprehensive test to verify that manual trigger jobs can be created without explicitly specifying these parameters and that they default to 1
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/containerapp/containerapp_job_decorator.py | Changed default values for replicaCompletionCount and parallelism from 0 to 1 for manual and schedule trigger configurations |
| src/azure-cli/azure/cli/command_modules/containerapp/tests/latest/test_containerappjob_crud.py | Added test case test_containerappjob_create_with_default_parallelism_and_completion_count to verify the new default behavior |
| src/azure-cli/azure/cli/command_modules/containerapp/tests/latest/recordings/test_containerappjob_create_with_default_parallelism_and_completion_count.yaml | Added test recording file for the new test case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greedygre
reviewed
Feb 5, 2026
src/azure-cli/azure/cli/command_modules/containerapp/containerapp_job_decorator.py
Outdated
Show resolved
Hide resolved
Greedygre
reviewed
Feb 9, 2026
src/azure-cli/azure/cli/command_modules/containerapp/containerapp_job_decorator.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Please fix CI issues |
Contributor
Author
|
Hi, @yanzhudd / @Greedygre / @yonzhan thank you for taking a look at this PR! It appears the CI failures are unrelated to my changes. Do you have any advice/thoughts on what could be going wrong, or re-trigger if they seem to be transient? Thanks in advance for your help! |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
Hi @jepetty |
yanzhudd
changed the title
az containerapp job create Default to the required defaults from the CPaz containerapp job create: Set default values to --parallelism and --replica-completion-count parameters
Contributor
Author
|
Thank you @yanzhudd! Yes, this PR is ready for review/merge :) |
yanzhudd
approved these changes
Feb 19, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp job create --name job-test-1 --resource-group jepetty-week1 --environment job-test-cc --trigger-type "Manual" --replica-timeout 1800 --image "mcr.microsoft.com/k8se/quickstart-jobs:latest" --cpu '0.25' --memory '0.5Gi' --replica-retry-limit 1Description
Testing Guide
az containerapp env create --name job-test-cc --resource-group jepetty-week1az containerapp job create --name job-test-1 --resource-group jepetty-week1 --environment job-test-cc --trigger-type "Manual" --replica-timeout 1800 --image "mcr.microsoft.com/k8se/quickstart-jobs:latest" --cpu '0.25' --memory '0.5Gi' --replica-retry-limit 1Expected to provide intelligent defaults accepted by the control-plane. Today, you get an API error about how these values should not be 0.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.