Conversation
🔄AzureCLI-FullTest
|
|
Hi @Shekar2004, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a generated CLI module for Azure Confluent, enabling management of Confluent organizations, environments, clusters, topics, connectors, and related resources through the Azure CLI. The code is generated by aaz-dev-tools and implements the AAZ (Azure API for Azure CLI) pattern.
Changes:
- Adds comprehensive AAZ command implementations for Confluent service operations
- Implements commands for organizations, environments, clusters, schema registries, topics, connectors, API keys, role bindings, validations, and marketplace agreements
- Includes module structure with loader, commands, parameters, help, and test scaffolding
Reviewed changes
Copilot reviewed 78 out of 78 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
__init__.py |
Module loader with AAZ command table loading |
commands.py, custom.py, _params.py, _help.py |
Placeholder files for command registration and customization |
aaz/latest/confluent/* |
Generated AAZ command implementations for all Confluent operations |
tests/ |
Test structure with placeholder test class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # -------------------------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # | ||
| # Code generated by aaz-dev-tools | ||
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| from azure.cli.core import AzCommandsLoader | ||
| from azure.cli.command_modules.cli_new_extension._help import helps # pylint: disable=unused-import | ||
| # from azure.cli.core.profiles import ResourceType # required when using python sdk | ||
|
|
||
|
|
||
| class CliNewExtensionCommandsLoader(AzCommandsLoader): | ||
|
|
||
| def __init__(self, cli_ctx=None): | ||
| from azure.cli.core.commands import CliCommandType | ||
| custom_command_type = CliCommandType( | ||
| operations_tmpl='azure.cli.command_modules.cli_new_extension.custom#{}') | ||
| super().__init__(cli_ctx=cli_ctx, | ||
| # resource_type=ResourceType.XXX # required when using python sdk | ||
| custom_command_type=custom_command_type) | ||
|
|
||
| def load_command_table(self, args): | ||
| from azure.cli.command_modules.cli_new_extension.commands import load_command_table | ||
| from azure.cli.core.aaz import load_aaz_command_table | ||
| try: | ||
| from . import aaz | ||
| except ImportError: | ||
| aaz = None | ||
| if aaz: | ||
| load_aaz_command_table( | ||
| loader=self, | ||
| aaz_pkg_name=aaz.__name__, | ||
| args=args | ||
| ) | ||
| load_command_table(self, args) | ||
| return self.command_table | ||
|
|
||
| def load_arguments(self, command): | ||
| from azure.cli.command_modules.cli_new_extension._params import load_arguments | ||
| load_arguments(self, command) | ||
|
|
||
|
|
||
| COMMAND_LOADER_CLS = CliNewExtensionCommandsLoader |
There was a problem hiding this comment.
The module directory name 'cli_new_extension' appears to be a placeholder or incorrect name for the Confluent CLI module. The module should be named 'confluent' to match the command group being registered. This inconsistency will cause confusion and doesn't follow the naming convention where the module name typically matches the command group name (e.g., 'vm' module for 'az vm', 'network' module for 'az network').
| class CliNewExtensionScenario(ScenarioTest): | ||
| # TODO: add tests here | ||
| pass |
There was a problem hiding this comment.
The test file contains only a placeholder test class with a TODO comment and no actual test implementation. Given that this is a generated CLI module with extensive functionality (organizations, environments, clusters, topics, connectors, API keys, role bindings, etc.), this lacks adequate test coverage. While this is marked as generated code, tests should still be implemented to verify the commands work correctly.
|
@Shekar2004 may i ask why you created prs both on ext and azure-cli? Azure/azure-cli-extensions#9618 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
4 participants
Related command
Related command: az confluent
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.