Skip to content

Remove unused code from azure-json and azure-xml #47612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alzimmermsft wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove unused code from azure-json and azure-xml #47612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c15358
Remove unused code
alzimmermsft Oct 23, 2025
fc9b8bc
Finalize cleaning up
alzimmermsft Oct 23, 2025
6ad8018
Merge branch 'main' into AzJson_RemoveDeadCode
alzimmermsft Dec 29, 2025
2c622df
Remove some additional dead code
alzimmermsft Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 4 additions & 44 deletions sdk/serialization/azure-json/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@

<FindBugsFilter xmlns="https://github.com/spotbugs/filter/3.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
<Match>
<Bug pattern="CT_CONSTRUCTOR_THROW" />
<Or>
<Class name="com.azure.json.implementation.jackson.core.io.SerializedString" />
<Class name="com.azure.json.implementation.jackson.core.type.TypeReference" />
<Class name="com.azure.json.implementation.jackson.core.util.RequestPayload" />
</Or>
</Match>
<Match>
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS" />
<Class name="com.azure.json.implementation.jackson.core.util.InternCache" />
Expand All @@ -21,38 +13,18 @@
<Class name="com.azure.json.implementation.jackson.core.io.ContentReference" />
</Or>
</Match>
<Match>
<Bug pattern="MS_MUTABLE_ARRAY" />
<Class name="com.azure.json.implementation.jackson.core.JsonGenerator" />
</Match>
<Match>
<Bug pattern="MS_PKGPROTECT" />
<Or>
<Class name="com.azure.json.implementation.jackson.core.json.JsonGeneratorImpl" />
<Class name="com.azure.json.implementation.jackson.core.json.ReaderBasedJsonParser" />
<Class name="com.azure.json.implementation.jackson.core.json.UTF8StreamJsonParser" />
<Class name="com.azure.json.implementation.jackson.core.json.WriterBasedJsonGenerator" />
</Or>
</Match>
<Match>
<Bug pattern="OBL_UNSATISFIED_OBLIGATION" />
<Class name="com.azure.json.implementation.jackson.core.JsonFactory" />
</Match>
<Match>
<Bug pattern="PATH_TRAVERSAL_IN" />
<Class name="com.azure.json.implementation.jackson.core.TokenStreamFactory" />
</Match>
<Match>
<Bug pattern="REC_CATCH_EXCEPTION" />
<Class name="com.azure.json.implementation.jackson.core.util.VersionUtil" />
</Match>
<Match>
<Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
<Or>
<Class name="com.azure.json.implementation.jackson.core.util.JsonGeneratorDelegate" />
<Class name="com.azure.json.implementation.jackson.core.util.JsonParserDelegate" />
</Or>
</Match>
<Match>
<Bug pattern="SE_BAD_FIELD" />
<Class name="com.azure.json.implementation.jackson.core.JsonFactory" />
</Match>
<Match>
<Bug pattern="SF_SWITCH_FALLTHROUGH" />
<Or>
Expand All @@ -64,16 +36,4 @@
<Bug pattern="SF_SWITCH_NO_DEFAULT" />
<Class name="com.azure.json.implementation.jackson.core.io.NumberInput" />
</Match>
<Match>
<Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
<Class name="com.azure.json.implementation.jackson.core.type.WritableTypeId" />
</Match>
<Match>
<Bug pattern="URLCONNECTION_SSRF_FD" />
<Class name="com.azure.json.implementation.jackson.core.TokenStreamFactory" />
</Match>
<Match>
<Bug pattern="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD" />
<Class name="com.azure.json.implementation.jackson.core.type.WritableTypeId" />
</Match>
</FindBugsFilter>
4 changes: 2 additions & 2 deletions ...rialization/azure-json/src/main/java/com/azure/json/implementation/DefaultJsonReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* Default {@link JsonReader} implementation.
*/
public final class DefaultJsonReader extends JsonReader {
private static final JsonFactory FACTORY = JsonFactory.builder().build();
private static final JsonFactory FACTORY = new JsonFactory();

private final JsonParser parser;
private final byte[] jsonBytes;
Expand Down Expand Up @@ -89,7 +89,7 @@ private DefaultJsonReader(JsonParser parser, boolean resetSupported, byte[] json
this.parser = parser;
this.resetSupported = resetSupported;
this.parser.configure(JsonReadFeature.ALLOW_NON_NUMERIC_NUMBERS.mappedFeature(), nonNumericNumbersSupported);
this.parser.configure(JsonParser.Feature.ALLOW_COMMENTS, jsoncSupported);
this.parser.configure(JsonReadFeature.ALLOW_JAVA_COMMENTS.mappedFeature(), jsoncSupported);
this.jsonBytes = jsonBytes;
this.jsonString = jsonString;
this.nonNumericNumbersSupported = nonNumericNumbersSupported;
Expand Down
2 changes: 1 addition & 1 deletion ...rialization/azure-json/src/main/java/com/azure/json/implementation/DefaultJsonWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
* Default {@link JsonWriter} implementation.
*/
public final class DefaultJsonWriter extends JsonWriter {
private static final JsonFactory FACTORY = JsonFactory.builder().build();
private static final JsonFactory FACTORY = new JsonFactory();

private final JsonGenerator generator;

Expand Down
Loading
Loading