Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14219#48167

Merged
azure-sdk merged 5 commits intomainfrom
sync-eng/common-AddGHAppWorkflowLogin-14219
Mar 2, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14219#48167
azure-sdk merged 5 commits intomainfrom
sync-eng/common-AddGHAppWorkflowLogin-14219

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14219 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner February 27, 2026 23:05
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Feb 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronizes eng/common GitHub authentication tooling with azure-sdk-tools by extending the existing login-to-github.ps1 script to support GitHub Actions and introducing a composite action wrapper for workflows.

Changes:

  • Update login-to-github.ps1 to support exporting/masking tokens in GitHub Actions and improve signing error output.
  • Add a new composite GitHub Action (eng/common/actions/login-to-github) that wraps the PowerShell script for workflow usage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
eng/common/scripts/login-to-github.ps1 Adds GitHub Actions export/masking behavior and updates error handling text when Key Vault signing fails.
eng/common/actions/login-to-github/action.yml Introduces a composite action wrapper that invokes login-to-github.ps1 from GitHub Actions with configurable inputs.

@azure-sdk azure-sdk merged commit 770a9d7 into main Mar 2, 2026
21 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-AddGHAppWorkflowLogin-14219 branch March 2, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants