Skip to content

Increase timeout for circuit breaker E2E tests #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkyberneees merged 1 commit into from
Nov 9, 2025
Merged

Increase timeout for circuit breaker E2E tests #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/circuit-breaker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ describe('Circuit Breaker E2E', () => {
})

await gateway.listen()
await new Promise((r) => setTimeout(r, 200))
await new Promise((r) => setTimeout(r, 1000))
Copy link

Copilot AI Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test now uses a 1000ms delay while other similar tests in the same file use 200ms (lines 35, 82, 125). This inconsistency makes the test suite slower and harder to maintain. Consider either using the same 200ms delay for consistency, or if this test genuinely needs more time, add a comment explaining why this specific test requires a longer delay.

Suggested change
await new Promise((r) => setTimeout(r, 1000))
await new Promise((r) => setTimeout(r, 200))

Copilot uses AI. Check for mistakes.

try {
const response = await fetch(
Expand Down
Loading