Support PHP 8.0 through 8.4#3
Closed
lphoumpakka wants to merge 2 commits into
Closed
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 60d0b94. Configure here.
|
|
||
| - name: Install composer dependencies | ||
| run: composer install | ||
| run: composer install ${{ matrix.php-version == '8.0' && '--ignore-platform-reqs' || '' }} |
There was a problem hiding this comment.
PHP 8.4 CI install fails
High Severity
The workflow adds a PHP 8.4 matrix job but only passes --ignore-platform-reqs for PHP 8.0. The locked dev dependency vimeo/psalm (5.26.1) declares support only through PHP 8.3, so a normal composer install on 8.4 should fail platform checks and the Codesniffer job for 8.4 never reaches composer cs.
Reviewed by Cursor Bugbot for commit 60d0b94. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Runtime requirement is relaxed and CI/tooling only; Facet.php changes are style/suppressions with no logic changes.
Overview
Widens official PHP support from 8.3-only to
^8.0, dropping Composer’s pinnedplatform.php8.3 so installs are no longer forced to that runtime.CI and tooling follow the new range: the quality workflow runs codesniffer on a matrix of PHP 8.0 and 8.4 (8.0 installs deps with
--ignore-platform-reqs), release builds use PHP 8.4, and PHPCompatibility inphpcs.xmlis set to8.0-.classes/Facet.phponly gets a spacing fix inisset()and PHPCS suppressions around the existing dynamicslug IN (...)delete query—no behavioral change.composer.lockis regenerated (dev dependency bumps, includingroots/wordpress-no-content6.9.4 and refreshedroave/security-advisories).Reviewed by Cursor Bugbot for commit 9470a98. Bugbot is set up for automated code reviews on this repo. Configure here.