Skip to content

Broaden PHP requirement to ^8.0 for 8.0–8.4 compatibility #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lphoumpakka merged 2 commits into from
Jun 11, 2026
Merged

Broaden PHP requirement to ^8.0 for 8.0–8.4 compatibility #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b43b19
Broaden PHP requirement to ^8.0 for 8.0–8.4 compatibility
lphoumpakka Jun 11, 2026
f15bb39
update composer lock
lphoumpakka Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions classes/Facet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ protected function parse_side( $side ): object {
public function get_p2p_connexion(): array {
static $load_connexions;

if ( isset( $load_connexions) ) {
if ( isset( $load_connexions ) ) {
return $load_connexions;
}

Expand Down Expand Up @@ -411,11 +411,12 @@ public function p2p_delete_connections( $p2p_ids ): void {
continue;
}

$facet_name_in = "'";
$facet_name_in = "'"; //phpcs:ignore Generic.Formatting.MultipleStatementAlignment.NotSameWarning
$facet_name_in .= implode( "', '", $names );
$facet_name_in .= "'";

$wpdb->query(
//phpcs:disable WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$wpdb->prepare(
"
DELETE FROM {$wpdb->prefix}wpgb_index
Expand All @@ -429,6 +430,7 @@ public function p2p_delete_connections( $p2p_ids ): void {
$connexion->p2p_to,
)
);
//phpcs:enable
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
}
},
"require": {
"php": "8.3.*",
"php": "^8.0",
"ext-json": "*",
"composer/installers": "^1.0 || ^2.0"
},
Expand Down
Loading
Loading