Preserve numeric types for literal subtree port values#1121
Open
L4co77 wants to merge 1 commit intoBehaviorTree:masterfrom
Open
Preserve numeric types for literal subtree port values#1121L4co77 wants to merge 1 commit intoBehaviorTree:masterfrom
L4co77 wants to merge 1 commit intoBehaviorTree:masterfrom
Conversation
L4co77
force-pushed
the
fix-subtree-literal-numeric-types
branch
3 times, most recently
from
b629e8b to
c687d78
Compare
Collaborator
|
PR with unit test, what else can I ask? thanks, I will review and come back to you |
When literal values are passed to SubTree ports (not blackboard remapping), detect numeric types (int64_t, double) before storing them in the child blackboard. Previously all literals were stored as std::string, which caused type-mismatch errors in Script expressions that tried to do arithmetic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
L4co77
force-pushed
the
fix-subtree-literal-numeric-types
branch
from
c687d78 to
5e5f65b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When literal values are passed to SubTree ports (not blackboard remapping), detect numeric types (int64_t, double) before storing them in the child blackboard. Previously all literals were stored as std::string, which caused type-mismatch errors in Script expressions that tried to do arithmetic.