Skip to content

Fix dynamic rulebook example #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfremont wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Fix dynamic rulebook example #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions examples/dynamic_rulebook/multi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@
import numpy as np
from dotmap import DotMap

from verifai.samplers.scenic_sampler import ScenicSampler
from verifai.scenic_server import ScenicServer
from verifai.falsifier import generic_falsifier, generic_parallel_falsifier
from verifai.monitor import multi_objective_monitor, specification_monitor
from verifai.rulebook import Rulebook
from verifai import (
Falsifier, ParallelFalsifier, Monitor, Rulebook, ScenicSampler
)


def announce(message):
Expand Down Expand Up @@ -147,14 +145,13 @@ def run_experiment(
scenario_model=model,
num_workers=num_workers,
)
falsifier_class = generic_parallel_falsifier if parallel else generic_falsifier
falsifier_class = ParallelFalsifier if parallel else Falsifier
falsifier = falsifier_class(
monitor=rb, ## modified
sampler_type=s_type,
sampler=sampler,
falsifier_params=falsifier_params,
server_options=server_options,
server_class=ScenicServer,
)
print(f"(multi.py) Sampler type: {falsifier.sampler_type}")

Expand Down
9 changes: 5 additions & 4 deletions examples/dynamic_rulebook/run_multi_dynamic.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ log_file="result_${scenario}_${sampler_type}_${sampler_idx}_${use_dynamic_rulebo
result_file="result_${scenario}_${sampler_type}_${sampler_idx}_${use_dynamic_rulebook}.txt"
csv_file="result_${scenario}_${sampler_type}_${sampler_idx}_${use_dynamic_rulebook}"

rm $scenario/outputs/$log_file
rm $scenario/outputs/$result_file
rm $scenario/outputs/$csv_file.*csv
rm $scenario/outputs/$csv_file\_scatter.png
mkdir -p $scenario/outputs
rm -f $scenario/outputs/$log_file
rm -f $scenario/outputs/$result_file
rm -f $scenario/outputs/$csv_file.*csv
rm -f $scenario/outputs/$csv_file\_scatter.png
if [ "$use_dynamic_rulebook" = true ]; then

for seed in $(seq 0 1);
Expand Down
3 changes: 2 additions & 1 deletion src/verifai/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
from verifai.samplers import *
from verifai.scenic_server import ScenicServer
from verifai.server import Server
from verifai.falsifier import Falsifier
from verifai.falsifier import Falsifier, ParallelFalsifier
from verifai.monitor import Monitor
from verifai.rulebook import Rulebook
2 changes: 1 addition & 1 deletion src/verifai/rulebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from verifai.monitor import Monitor


class Rulebook(ABC):
class Rulebook(Monitor, ABC):

def __init__(
self,
Expand Down