Skip to content

fix: correct bernoulli_loader kwarg, remove duplicate import, fix mutable default #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haoyu-haoyu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: correct bernoulli_loader kwarg, remove duplicate import, fix mutable default #743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindsnet/encoding/loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def bernoulli_loader(
:param float max_prob: Maximum probability of spike per Bernoulli trial.
"""
# Setting kwargs.
max_prob = kwargs.get("dt", 1.0)
max_prob = kwargs.get("max_prob", 1.0)

for i in range(len(data)):
# Encode datum as Bernoulli spike trains.
Expand Down
4 changes: 0 additions & 4 deletions bindsnet/network/monitors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@

import numpy as np
import torch
import numpy as np

from abc import ABC
from typing import Union, Optional, Iterable, Dict

from bindsnet.network.nodes import Nodes
from bindsnet.network.topology import (
Expand Down
2 changes: 1 addition & 1 deletion bindsnet/network/topology.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ def __init__(
source: Nodes,
target: Nodes,
device: device,
pipeline: list = [],
pipeline: Optional[list] = None,
manual_update: bool = False,
traces: bool = False,
**kwargs,
Expand Down