Add material entity branch: protein, compound, condensate, and related classes#25
Merged
Add material entity branch: protein, compound, condensate, and related classes#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses point 4 (partial) of the review on OBOFoundry/OBOFoundry.github.io#2770.
The reviewer recommended defining compound, condensate, and biomolecular condensate as material entities so that quality terms like condensate material state and role terms like role in condensate assembly have formally defined bearers. In addition, IDPO needs protein and protein region as bearer classes for structural states, functions and roles that inhere in proteins or protein regions.
BFO:0000040 (material entity) was added to the BFO import seed list.
New Classes added:
Compound/condensate sub-branch (under material entity):
compound (IDPO:0000091)
condensate (IDPO:0000092)
biomolecular condensate (IDPO:0000093)
Protein sub-branch (under material entity):
protein (IDPO:0000094)
intrinsically disordered protein (IDPO:0000096)
protein region (IDPO:0000095)
intrinsically disordered region (IDPO:0000097)
ordered region (IDPO:0000098)