Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
742f057
Fix link
lshep Feb 28, 2023
120f39f
Merge branch 'Bioconductor:devel' into master
lshep Jun 20, 2023
d3c46cb
Fixes typo Fix #109
lshep Jun 20, 2023
9c08085
Merge branch 'master' of github.com:lshep/pkgrevdocs
lshep Jun 20, 2023
c9318e8
Merge branch 'Bioconductor:devel' into master
lshep Sep 12, 2023
a142fec
Update what to expect
lshep Sep 12, 2023
39d7f6c
Merge branch 'Bioconductor:devel' into master
lshep Feb 29, 2024
e5dde32
Merge branch 'Bioconductor:devel' into master
lshep Feb 29, 2024
261d877
strengthen wording for basilisk requirement instead of reticulate as …
lshep Feb 29, 2024
d9447ef
Merge branch 'Bioconductor:devel' into master
lshep Aug 12, 2024
6bc06af
Merge branch 'Bioconductor:devel' into master
lshep Nov 20, 2024
504b9b2
Update System Dependency section with @vjctin suggested text
lshep Nov 20, 2024
dcff8ac
Merge branch 'Bioconductor:devel' into master
lshep Dec 2, 2024
c27168b
Fixes #128
lshep Dec 2, 2024
04c55dc
Merge branch 'Bioconductor:devel' into master
lshep Apr 9, 2025
01739bd
Add note about submitter should be maintainer
lshep Apr 9, 2025
a807146
Merge branch 'Bioconductor:devel' into master
lshep Jun 9, 2025
d590852
Extend end of life description
lshep Jun 9, 2025
3523f0d
Merge branch 'Bioconductor:devel' into master
lshep Jun 9, 2025
d2c5187
Merge branch 'Bioconductor:devel' into master
lshep Nov 13, 2025
bf000da
Change package size to 10 MB
lshep Nov 13, 2025
e1ec8e6
Merge branch 'Bioconductor:devel' into master
lshep May 1, 2026
d0b8df1
Update checklist
lshep May 1, 2026
af45ecd
add no renv
lshep May 4, 2026
3de8225
Add checklist item for renv directory and lock file
lshep May 4, 2026
25b9e54
Merge branch 'Bioconductor:devel' into master
lshep May 28, 2026
87312ee
Merge branch 'master' of github.com:lshep/pkgrevdocs
lshep May 28, 2026
4b17665
Add ai / third party policy
lshep May 28, 2026
558cf7a
Merge branch 'Bioconductor:devel' into master
lshep May 28, 2026
3ecaeab
Add section on building and checking
lshep May 28, 2026
f6251c2
Merge branch 'master' of github.com:lshep/pkgrevdocs
lshep May 28, 2026
2486730
Merge branch 'Bioconductor:devel' into master
lshep Jun 5, 2026
859560f
Update for new SPB tracker
lshep Jun 5, 2026
290cb0d
Update to link to the new submission process
lshep Jun 5, 2026
3e1090e
Update for new SPB
lshep Jun 5, 2026
544c02b
Merge branch 'Bioconductor:devel' into master
lshep Jun 5, 2026
695ab68
add note about testing coverage
lshep Jun 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/package-review-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ strongly recommended.

## Unit tests

- [ ] Unit tests present and covering large part of core functionality.
- [ ] Unit tests present and covering large part of core functionality. (recommend testing with `covr::package_coverage()`)

## R code

Expand Down
6 changes: 5 additions & 1 deletion unit-tests.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ complete set of tests.
RUnit, tinytest, and testthat are robust testing solutions that are great tools
for package development, which you choose to use for your package largely comes
down to personal preference. However here is a brief list of strengths and
weaknesses of each.
weaknesses of each. Bioconductor slighlty prefers testthat

### RUnit Strengths ###

Expand Down Expand Up @@ -343,11 +343,15 @@ refers to the percentage of your package code
that is tested by your unit tests. Packages with higher coverage
have a lower chance of containing bugs.

We highly recommend using the [covr package](https://cran.r-project.org/web/packages/covr/index.html) function
`package_coverage()` for evaluation.

If tests are taking too long to achieve full test coverage, see [long tests][].
Before implementing long tests we highly recommend reaching out to the
bioconductor team on the [bioc-devel][bioc-devel-mail] mailing list to ensure
proper use and justification.


## Additional Resources

Some web resources worth reading:
Expand Down
Loading