Skip to content

Improve user-facing error messages for clarity#302

Open
SLC-BTC wants to merge 1 commit intoBlockstream:masterfrom
SLC-BTC:improve-error-messages
Open

Improve user-facing error messages for clarity#302
SLC-BTC wants to merge 1 commit intoBlockstream:masterfrom
SLC-BTC:improve-error-messages

Conversation

@SLC-BTC
Copy link
Copy Markdown

@SLC-BTC SLC-BTC commented Apr 9, 2026

Summary

  • Rewrites ~40 cryptic/technical error messages in the string catalog to use plain language with actionable guidance
  • Replaces hardcoded "Device wasn't found" in LoginViewModel.kt with proper id_ localization key
  • Fixes grammar issues ("Could not recognized" → "Could not recognize")
  • Tones down alarming hardware wallet error message about compromise
  • Adds 8 new localization keys to match iOS companion PR

Examples of changes

Before After
"Operation failure" "Something went wrong. Please try again or contact support if the issue persists."
"Could not recognized QR code" "Could not recognize this QR code. Please try scanning again."
"Invalid mnemonic" "The recovery phrase you entered is not valid. Please check and try again."
"Insufficient funds" "You don't have enough funds for this transaction."
"Invalid status. Check that your device is unlocked and try again." "Your device may be locked or unresponsive. Please unlock it and try again."
"Device wasn't found" Uses id_your_device_was_disconnected localization key

Companion PR: Blockstream/green_ios#95

Test plan

  • Verify app builds successfully with no missing string key references
  • Exercise key error paths: wrong PIN, invalid address, disconnect hardware wallet, timeout scenarios
  • Confirm new error messages render correctly in dialogs and snackbars
  • Non-English translations are unchanged and will need a separate translation pass

🤖 Generated with Claude Code

Rewrite ~40 error messages in the string catalog and fix a hardcoded
string in LoginViewModel to use plain language, provide actionable
guidance, and eliminate cryptic technical jargon. Key changes:

- Replace generic messages like "Operation failure", "Failed", "Timeout"
  with explanations of what went wrong and what to do next
- Fix grammar issues ("Could not recognized" -> "Could not recognize")
- Replace hardcoded "Device wasn't found" with localization key
- Tone down alarming hardware wallet error messages
- Add 8 new localization keys to match iOS companion PR

Companion PR: Blockstream/green_ios (improve-error-messages branch)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant