Asserts function refactoring#11
Open
aritkulova wants to merge 2 commits into
Open
Conversation
aritkulova
commented
Jun 11, 2026
aritkulova
commented
Collaborator
- removed unsuported "pub" modifier;
- renamed asserts functions;
- made asserts test more detailed;
- added random generation of test data instead of constants;
- added enums and constants to test for better readability.
removed unsuported "pub" modifier
added random generation of test data
aritkulova
force-pushed
the
feat/asserts-refactoring
branch
from
69c088f to
fa1984e
Compare
This was referenced Jun 11, 2026
stringhandler
approved these changes
Jun 12, 2026
stringhandler
left a comment
stringhandler
left a comment
Collaborator
There was a problem hiding this comment.
Seems like a lot of complicated code to test some trivial methods, but the .simf files look fine
Collaborator
|
The problem with removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.