ENH: Move non-trivial Filter executeImpl() logic to Algorithm classes#1544
Open
imikejackson wants to merge 1 commit intodevelopfrom
Open
ENH: Move non-trivial Filter executeImpl() logic to Algorithm classes#1544imikejackson wants to merge 1 commit intodevelopfrom
imikejackson wants to merge 1 commit intodevelopfrom
Conversation
imikejackson
force-pushed
the
topic/move_to_algorithm_classes
branch
4 times, most recently
from
4f321d4 to
d9fee72
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/TriangleDihedralAngle.cpp
Outdated
Show resolved
Hide resolved
…1284) Convert 24 filters to use the Algorithm class pattern by moving execute logic from Filter files into dedicated Algorithm classes. Each filter now extracts parameters into an InputValues struct and delegates to an Algorithm operator()(). This improves separation of concerns and follows the established codebase pattern. Filters converted: ChangeAngleRepresentation, ComputeFeatureNeighbors, ComputeFeaturePhases, ComputeFeaturePhasesBinary, CopyFeatureArrayToElementArray, CreateFeatureArrayFromElementArray, CreateGeometry, CropImageGeometry, CropVertexGeometry, ExtractPipelineToFile, InitializeImageGeomCellData, InterpolatePointCloudToRegularGrid, MultiThresholdObjects, ReadHDF5Dataset, ReadTextDataArray, RemoveFlaggedVertices, ReverseTriangleWinding, RobustAutomaticThreshold, TriangleDihedralAngle, TriangleNormal, WriteASCIIData, WriteBinaryData, WriteDREAM3D, WriteFeatureDataCSV Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
imikejackson
force-pushed
the
topic/move_to_algorithm_classes
branch
from
d9fee72 to
6e7d884
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1284
Convert 24 filters to use the Algorithm class pattern by moving execute logic from Filter files into dedicated Algorithm classes. Each filter now extracts parameters into an InputValues struct and delegates to an Algorithm operator()(). This improves separation of concerns and follows the established codebase pattern.
Filters converted: