ENH: Add algorithm dispatch for IdentifySample OOC optimization#1545
Open
joeykleingers wants to merge 1 commit intoBlueQuartzSoftware:developfrom
Open
ENH: Add algorithm dispatch for IdentifySample OOC optimization#1545joeykleingers wants to merge 1 commit intoBlueQuartzSoftware:developfrom
joeykleingers wants to merge 1 commit intoBlueQuartzSoftware:developfrom
Conversation
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
d801a0a to
1bda2d9
Compare
Split IdentifySample into two algorithm implementations selected at runtime based on whether arrays use out-of-core (chunked) storage: - IdentifySampleBFS: BFS flood fill optimized for in-core data (1 bit/voxel) - IdentifySampleCCL: Scanline CCL with union-find optimized for OOC data Add reusable AlgorithmDispatch.hpp utility (IsOutOfCore, AnyOutOfCore, DispatchAlgorithm) so other filters can adopt the same pattern. In-core benchmark: 0.17s (was 0.23s, 1.4x faster) OOC benchmark: 1.9s (was 841s, 475x faster) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joeykleingers
force-pushed
the
worktree-identify-sample-optimizations
branch
from
1bda2d9 to
c88c7f6
Compare
imikejackson
requested changes
Feb 24, 2026
Contributor
imikejackson
left a comment
imikejackson
left a comment
There was a problem hiding this comment.
As we discussed, there needs to be a clear path to exercise both code paths even with out-of-core is not being built. This PR should not be merged until this is figured out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlgorithmDispatch.hpputility (IsOutOfCore,AnyOutOfCore,DispatchAlgorithm) for other filters to adopt the same patterndocs/AlgorithmDispatch.md) explaining when and how to use algorithm dispatchPerformance
Test plan
🤖 Generated with Claude Code