This repository was archived by the owner on May 12, 2026. It is now read-only.
Restore copy behavior in Vim keymap#1685
Open
Bigsunnyboy wants to merge 1 commit into
Open
Conversation
CodeMirror's Vim keymap consumes Ctrl-C on Windows and Linux before the editor can copy selected text. The fix adds a small shared extraKeys handler that invokes the browser copy command for Vim editors and then returns CodeMirror.Pass so CodeMirror can continue its normal handling. Constraint: Keep the change scoped to the existing CodeMirror editor configuration Rejected: Rework user-customizable keybindings | larger UI and settings change than the bounty issue requires Confidence: medium Scope-risk: narrow Directive: Keep this handler attached to every cloud editor configuration that supports the Vim keymap Tested: npx eslint src/cloud/lib/editor/vimKeyMap.ts src/cloud/components/Editor/index.tsx src/cloud/lib/hooks/editor/docEditor.ts --ext .ts,.tsx Tested: npx tsc --noEmit --pretty false Not-tested: Manual Windows/Linux Electron clipboard flow
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #773.
Verification
Notes
IssueHunt Summary
Referenced issues
This pull request has been submitted to: