Add support for lazy texture loading#163
Open
iProgramMC wants to merge 2 commits into
Open
Conversation
This isn't an important or necessary memory allocation as BinaryReader supports just reading from the file in question, so the allocation failing isn't exactly "fatal".
This helps with memory usage on systems with less memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help alleviate some memory usage concerns on platforms with less than, like, 128 MB of usable RAM. Previous versions were holding the compressed asset data in memory in a useless manner. (rarely do you need to reuse a
Texture'sblobDataafter you already load the texture into memory)