Update API key environment variable name in Readme.md#47
Merged
Conversation
Owner
|
@Med-Yassine-B You're right. I forgot to check what the prod code expects to receive Example: git commit --amend -m "fix(#42): update the api key variable name in readme"
git push --force-with-lease |
BytecodeBrewer
approved these changes
Jun 17, 2026
Collaborator
Author
|
@BytecodeBrewer It looks like i missed the commit workflow on CONTRIBUTING.md |
Owner
|
@Med-Yassine-B Great, now I merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI ✌️ i noticed a typo in the README.md file while trying to run the project
In the build instructions the API key name in the .env is written like this
api_key=the_actual_api_key
while the python code expects
EXCHANGE_RATE_API_KEY=the_actual_api_key
What changed?
Related issue
// no related issue
Tests
pytestChecklist
Notes