Skip to content

Update API key environment variable name in Readme.md#47

Merged
BytecodeBrewer merged 1 commit into
BytecodeBrewer:developfrom
Med-Yassine-B:patch-1
Jun 17, 2026
Merged

Update API key environment variable name in Readme.md#47
BytecodeBrewer merged 1 commit into
BytecodeBrewer:developfrom
Med-Yassine-B:patch-1

Conversation

@Med-Yassine-B

@Med-Yassine-B Med-Yassine-B commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

HI ✌️ i noticed a typo in the README.md file while trying to run the project
In the build instructions the API key name in the .env is written like this

api_key=the_actual_api_key

while the python code expects
EXCHANGE_RATE_API_KEY=the_actual_api_key

What changed?

  • Updated the README.md

Related issue

// no related issue

Tests

  • I ran pytest
  • Existing tests pass
  • I added or updated tests where necessary
  • Not needed because this only affects documentation or repository setup

Checklist

  • The change is focused
  • No secrets or API keys are included
  • Documentation was updated if needed
  • CI is expected to pass

Notes

@BytecodeBrewer

BytecodeBrewer commented Jun 17, 2026

Copy link
Copy Markdown
Owner

@Med-Yassine-B You're right. I forgot to check what the prod code expects to receive
Edit: Please amend your commit because it doesn't follow the commit convention.

Example:

git commit --amend -m "fix(#42): update the api key variable name in readme"
git push --force-with-lease

@BytecodeBrewer BytecodeBrewer modified the milestone: Sprint 2 Jun 17, 2026
@BytecodeBrewer BytecodeBrewer added the documentation Improvements or additions to documentation label Jun 17, 2026
@BytecodeBrewer BytecodeBrewer self-requested a review June 17, 2026 19:39
@Med-Yassine-B

Copy link
Copy Markdown
Collaborator Author

@BytecodeBrewer It looks like i missed the commit workflow on CONTRIBUTING.md
i edited my commit as required

@BytecodeBrewer BytecodeBrewer merged commit a9a6151 into BytecodeBrewer:develop Jun 17, 2026
2 checks passed
@BytecodeBrewer

Copy link
Copy Markdown
Owner

@Med-Yassine-B Great, now I merged it.

@Med-Yassine-B Med-Yassine-B deleted the patch-1 branch June 17, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants