Add typings to some parts of the code by MangoTCF · Pull Request #96 · C0rn3j/sc-controller

MangoTCF · 2026-01-27T10:50:16Z

This PR is part 1 of many.
Files modified by me are:

tools.py
actions.py
aliases.py
config.py
mapper.py
special_actions.py
uinut.py

Other files are reformatted via ruff as per the configuration in pyproject.toml
As open as i could be to constructive criticism, as this is my first more or less serious PR.

C0rn3j · 2026-01-27T14:47:38Z

You should be able to drop the format everything with ruff commit, I've taken in most of the changes that Ruff recommended, still need to later mark the areas I left out so it does not touch it on the next run.

Hopefully this does not make it too annoying to drop the commit and rebase.

I'm planning to also run ruff check --fix later to catch other easy issues.

add typings to TODO

more understandable code

MangoTCF · 2026-01-27T15:27:37Z

Shot myself in the foot with git a bit, everything should be a-ok now

MangoTCF · 2026-01-27T20:42:00Z

Should I infer and add a complete, really big, type to the config in config.py or is it being a dict[str, Any] enough?

C0rn3j · 2026-01-27T21:06:41Z

We can always make it more specific later if desired, Any is probably fine there

MangoTCF · 2026-01-27T21:17:22Z

Also we really need to migrate away from PyGObject as it at the very least messes with typecheckers

And, like, the whole GTK5 release = GTK3 EOL thing

I propose Qt 6 as it looks like thay are moving in the right direction

C0rn3j · 2026-01-28T15:21:22Z


 	def __init__(self):
-		self.in_use = False
+		super().__init__()


Do we really need to init the super class here?

Linter complains :) It's better to do that for code consistency etc.

C0rn3j · 2026-01-28T15:30:06Z

+			# why not move size to be the second argument then?
 			control_with, size = DEFAULT, control_with


It's a cursed shorthand.

>>> x, y = 1, 2 >>> x, y = 3, x >>> print(x, y) 3 1

Yeah, i get it, but why do
def f(a, b, c=DEFAULT, ..., shorthand_notation_thing=0):
if one can do
def f(a, b, shorthand_notation_thing=0, c=DEFAULT, ...):
?

C0rn3j · 2026-01-28T15:32:27Z


-	def whole(self, mapper, x, y, what):
+	@override
+	def whole(self, mapper, x: int | float, y: int | float, what: str, *_params):


Why the added *_params?

My linter says that this method "overrides in an incompatible way". There's some more errors like this, but I'd need some more experience with the codebase to be sure how to fix them

Basically, the signatures of the methods should be compatible as per the docs which IMHO is a good idea

C0rn3j · 2026-01-28T15:36:05Z

I've unresolved some things you've set as resolved without a change/answer and added some more.

I think besides the currently open conversations, this is LGTM, so please let's get this PR in before expanding it further, it's getting hard to review, thanks!

MangoTCF · 2026-01-29T13:37:43Z

Also to avoid having to do the whole rebasing thing on the next PR you could run ruff check --fix which would supposedly fix everything that's safe to fix.

MangoTCF · 2026-01-29T19:04:48Z

@C0rn3j could you please look through the open conversations and affirm that everything is OK and my reasons for doing the things I did are valid?

C0rn3j · 2026-01-29T20:10:50Z

Did you perhaps Start a review but never sent it in? I see no comments.

MangoTCF · 2026-01-27T14:20:27Z

 class Keys(IntEnum):
 	"""Keys enum contains all keys and button from linux/uinput.h (KEY_* BTN_*)."""
+
 	# TODO: Put these back when minimum Python version is... 3.10? https://github.com/C0rn3j/sc-controller/issues/24


Also, what's the stance with these TODOs? 3.09 is EOL as per this

MangoTCF · 2026-01-29T10:51:03Z


-	def whole(self, mapper, x, y, what):
+	@override
+	def whole(self, mapper, x: int | float, y: int | float, what: str, *_params):


Basically, the signatures of the methods should be compatible as per the docs which IMHO is a good idea

MangoTCF · 2026-01-29T22:59:07Z

Yup, you're completely right -_- i need to learn how to interface with all this better

MangoTCF · 2026-02-01T18:03:52Z

@C0rn3j Any updates? Or did i do something wrong again? :p

C0rn3j · 2026-02-03T11:24:28Z

+		vendor: int = int(cfg["output"]["vendor"], 16)
+		product: int = int(cfg["output"]["product"], 16)
+		version: int = int(cfg["output"]["version"], 16)
 		name = cfg["output"]["name"]


This seems unnecessarily verbose, ty can grep that this is an int.

It'd be something else if this were inside of an __init__ function, but it ain't.

I'll manually apply most of this instead of nitpicking into things further and asking to postpone some things for now, so we can get moving, so no need to edit the PR further.

That is fair, okay :D

C0rn3j · 2026-02-03T11:34:56Z

-		self.size = self.DEFAULT_SIZE
+		self.action: Action | None = None
+		self.timeout: float = self.DEFAULT_TIMEOUT
+		self.size: float = self.DEFAULT_SIZE


self.size looks like an int to me?

It looks like an int but it might be a float.. I didn't look into the function too much as the if len(parameters)>0 construct needs a refactoring to use default args anyways to avoid confusion and bugs

C0rn3j · 2026-02-03T12:07:26Z

-def find_button_image(name, prefer_bw=False):
+def find_button_image(
+	name: str | None, prefer_bw: bool = False
+) -> tuple[None, bool] | tuple[str, bool] | tuple[str, bool]:


You duped the return type here

C0rn3j · 2026-02-03T12:18:04Z

I'll check out the ruff check --fix stuff eventually, it's a lot to go through.

Sorry if I missed anything in the PR, I tried to include what I could while fixing what seemed wrong.

I deliberately left out Sequence typings (or converted them to lists where it seemed appropriate) as frankly, I don't get them at this point and I didn't have the time to properly learn them.

Further things were left out on purpose, some were left out simply because I wasn't sure if they should be there or not and didn't have the time to go through it all

One thing to note is that I reworked the SA = COMMAND = "text" to be SA = "text"; COMMAND = SA instead, as I fear something would inevitably break otherwise.

C0rn3j · 2026-02-03T12:49:33Z

Christ, those unused imports that you deleted are actually imported via star imports in the tests.

Not a fan of this codebase if I am being honest.

C0rn3j · 2026-02-04T15:49:51Z

I've now applied almost all of the ruff check --fix fixes.

Some of them were plain out breaking things, hoping that what made it in is fine, the changeset is quite large.

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/tools.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/tools.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/tools.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/tools.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/cemuhook_server.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/actions.py Outdated

MangoTCF force-pushed the main branch from 914b6f6 to 72e4586 Compare January 27, 2026 14:59

MangoTCF closed this Jan 27, 2026

MangoTCF force-pushed the main branch from 72e4586 to e9fb9c4 Compare January 27, 2026 15:02

MangoTCF added 4 commits January 27, 2026 18:15

Typings and grammar fixes in tools.py and cemuhook_server.py,

a5f4630

add typings to TODO

More typings and grammar fixes, renamed some variables for

91e748c

more understandable code

Fixes for the typings, add annotations import

38ddcc1

Add TYPE_CHECKING block for the import

d673519

MangoTCF reopened this Jan 27, 2026

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/uinput.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/uinput.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/uinput.py Outdated

Fix a surprising mistake

577d5e3

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/tools.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/special_actions.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/special_actions.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/cemuhook_server.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/cemuhook_server.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/aliases.py Outdated

Fixes for formatting

39d4764

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/special_actions.py Outdated

C0rn3j reviewed Jan 27, 2026

View reviewed changes

Comment thread scc/mapper.py Outdated

Various formatting fixes

639ac5f

MangoTCF changed the title ~~Add typings to some parts of the code and run a formatter on the codebase for the first time in seemingly ages~~ Add typings to some parts of the code Jan 27, 2026

C0rn3j reviewed Jan 28, 2026

View reviewed changes

Comment thread scc/mapper.py Outdated

C0rn3j reviewed Jan 28, 2026

View reviewed changes

Comment thread scc/aliases.py Outdated

C0rn3j reviewed Jan 28, 2026

View reviewed changes

Comment thread scc/uinput.py Outdated

C0rn3j reviewed Jan 28, 2026

View reviewed changes

Comment thread scc/tools.py Outdated

C0rn3j reviewed Jan 28, 2026

View reviewed changes

MangoTCF added 2 commits January 29, 2026 13:58

Yet some more fixes

3adbebd

Remove unnescessary int conversions

336d893

MangoTCF commented Jan 29, 2026

View reviewed changes

C0rn3j reviewed Feb 3, 2026

View reviewed changes

Comment thread scc/special_actions.py

C0rn3j reviewed Feb 3, 2026

View reviewed changes

C0rn3j closed this Feb 3, 2026

		# why not move size to be the second argument then?
		control_with, size = DEFAULT, control_with

Conversation

MangoTCF commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

C0rn3j commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MangoTCF commented Jan 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MangoTCF commented Jan 27, 2026

Uh oh!

C0rn3j commented Jan 27, 2026

Uh oh!

MangoTCF commented Jan 27, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

C0rn3j commented Jan 28, 2026

Uh oh!

MangoTCF commented Jan 29, 2026

Uh oh!

MangoTCF commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

C0rn3j commented Jan 29, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MangoTCF commented Jan 29, 2026

Uh oh!

MangoTCF commented Feb 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

MangoTCF commented Jan 27, 2026 •

edited

Loading

C0rn3j commented Jan 27, 2026 •

edited

Loading

MangoTCF commented Jan 29, 2026 •

edited

Loading

C0rn3j commented Feb 3, 2026 •

edited

Loading