Skip to content

Fix output filename handling in encoder context #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Invinsible-Coder wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −3
Open

Fix output filename handling in encoder context #2280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4036a6
Fix output filename handling in encoder context
Invinsible-Coder Jun 12, 2026
d20eb82
Remove unnecessary blank lines in ccx_encoders_common.c
Invinsible-Coder Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/lib_ccx/ccx_encoders_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,17 +1361,36 @@ void switch_output_file(struct lib_ccx_ctx *ctx, struct encoder_ctx *enc_ctx, in
if (enc_ctx->out->filename != NULL)
{ // Close and release the previous handle
free(enc_ctx->out->filename);
enc_ctx->out->filename = NULL;
close(enc_ctx->out->fh);
enc_ctx->out->fh = -1;
}

const char *ext = get_file_extension(ctx->write_format);
char suffix[32];
snprintf(suffix, sizeof(suffix), "_%d", track_id);
char *basename = get_basename(enc_ctx->out->original_filename);
if (basename != NULL)
if (basename == NULL)
{
return;
}

enc_ctx->out->filename = create_outfilename(basename, suffix, ext);
if (enc_ctx->out->filename == NULL)
{
enc_ctx->out->filename = create_outfilename(basename, suffix, ext);
enc_ctx->out->fh = open(enc_ctx->out->filename, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, S_IREAD | S_IWRITE);
free(basename);
return;
}

enc_ctx->out->fh = open(enc_ctx->out->filename, O_RDWR | O_CREAT | O_TRUNC | O_BINARY, S_IREAD | S_IWRITE);
free(basename);

if (enc_ctx->out->fh < 0)
{
// Clean up if the file descriptor failed to open
free(enc_ctx->out->filename);
enc_ctx->out->filename = NULL;
return;
}

write_subtitle_file_header(enc_ctx, enc_ctx->out);
Expand Down
Loading