-
Notifications
You must be signed in to change notification settings - Fork 69
feat:extend-shortcuts #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:extend-shortcuts #369
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Neeraj-gagat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added shortcuts keys to use in taskdialog
like up down arrow keys enter to go in edit mode
escape to exit edit mode when edit mode for one feild is open you can not open anot edit mode
and if you press escape when edit feild is not ope you can exit diaog but when edit feild is open you can exit edit feild
Neeraj-gagat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done with the self review new chages break nothing all the test pass and it works fine
let me know if i need to make chnages
|
Hey @its-me-abhishek while working on this feat I tried to add shortcuts to calender so we can use arrow keys to navigate through dates and select them but it did not work out do you have any suggestions how can I do that ? |
its-me-abhishek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do rename the PR title, old commits, as per the naming conventions in CONTRIBUTING.MD
On it 👍 |
its-me-abhishek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add unit tests for all these new files/changes
|
Hey @its-me-abhishek can you please clear my. doubt. About reverting changes ?? |
|
@Neeraj-gagat overall looks good, do add new test cases for Tasks & TasksDialog, will merge later. |
done 👍 |
|
Great Work overall @Neeraj-gagat! Thanks for the PR! |
Description
This Pr adds shortcuts for taskdialog
now we can naigate through task feilds using up && down arrow keys and
and by enter you can edit the feild
by escape yo can exit the editing state or by pressing escape when you are not editing anything you can exit dialog
- Fixes: #319
Additional Notes
will raise other pr for addtask dialog
video
Screencast.from.04-01-26.08.01.11.AM.IST.webm
let me know if i need to do any changes