-
Notifications
You must be signed in to change notification settings - Fork 69
refactor: batch task modification into single Taskwarrior command #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: batch task modification into single Taskwarrior command #373
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
|
Kindly add a self-code-review similar to this |
|
I’ve addressed the formatting issue and added inline self-review comments explaining the batching logic, UUID usage, and why annotations are handled separately. All required changes from my side should be complete now. |
|
@its-me-abhishek |
|
@its-me-abhishek |
|
@Harshkamboj11 the functions' usage in controllers should be updated as well, in order to make this work, currently it will break. |
|
@its-me-abhishek |
its-me-abhishek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested locally, and works fine. Although the tests seem to break, could you please add those as well?
|
@its-me-abhishek |
What changed
task modifycommandWhy
How it was tested
Notes