-
Notifications
You must be signed in to change notification settings - Fork 69
feat(AddTaskDialog): add DateTimePicker for start field #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(AddTaskDialog): add DateTimePicker for start field #376
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Show resolved
Hide resolved
ShivaGupta-14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review done, ready for review
9ab3a49 to
28bb73a
Compare
|
Hi @its-me-abhishek , thanks for the approval! |
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Outdated
Show resolved
Hide resolved
- Replace DatePicker with DateTimePicker for start field in AddTaskDialog - Add DateTimePicker mock in AddTaskDialog.test.tsx - Add comprehensive tests for DateTime fields (render, update, clear, submit) - Support both date-only and datetime formats Contributes: CCExtractor#325
28bb73a to
227b376
Compare
|
requested changes are done, happy to iterate based on your feedback |
|
@its-me-abhishek could you please review this |
Description
Replace DatePicker with DateTimePicker for start field in AddTaskDialog
Add DateTimePicker mock in AddTaskDialog.test.tsx
Add comprehensive tests for DateTime fields (render, update, clear, submit)
Support both date-only and datetime formats
Contributes: Add additional time picker for time(and date) based fields in AddTaskDialog #325
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Screenshots