Skip to content

Conversation

@ShivaGupta-14
Copy link
Contributor

Description

Additional Bug Found

While testing this fix, I discovered a related crash bug:

Steps to reproduce (before fix):

  1. Open "Add Task" dialog
  2. Click "No project"
  3. Click "Create new project"
  4. App crashes with black screen and removeChild DOM error

Video:

Before:

Screen.Recording.2026-01-06.at.7.05.30.PM.mov

After:

Screen.Recording.2026-01-06.at.7.10.31.PM.mov
  • This fix resolves both issues

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

- Fixes bug where selecting "No project" stored "__NONE__" instead of empty string. Added unit test for this edge case.

- Fixes: CCExtractor#377
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converts NONE to empty string when "No project" is selected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added unit test

Copy link
Contributor Author

@ShivaGupta-14 ShivaGupta-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review done! ready for review

@its-me-abhishek its-me-abhishek merged commit fddc3af into CCExtractor:main Jan 7, 2026
5 checks passed
@ShivaGupta-14 ShivaGupta-14 deleted the fix/377-no-project-value branch January 7, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting No project as Project on Add Task adds a __None__ value by default

2 participants