ipfix: fix stuck flushing loop after TCP disconnect in LZ4 mode#326
Merged
SiskaPavel merged 1 commit intomasterfrom May 4, 2026
Merged
ipfix: fix stuck flushing loop after TCP disconnect in LZ4 mode#326SiskaPavel merged 1 commit intomasterfrom
SiskaPavel merged 1 commit intomasterfrom
Conversation
In LZ4 compress mode, a failed send_packet() call in send_templates() left readSize non-zero, causing the next getWriteBuffer() in send_data() to return null and exit without clearing template buffers. Fix by adding CompressBuffer::getWriteBufferOrReset() which resets via shrinkTo(0) and retries once on null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LZ4 compress mode, a failed send_packet() call in send_templates() left readSize non-zero, causing the next getWriteBuffer() in send_data() to return null and exit without clearing template buffers.
Fix by adding CompressBuffer::getWriteBufferOrReset() which resets via shrinkTo(0) and retries once on null.