Conversation
youen
force-pushed
the
auto-commit-after-timeout
branch
from
7fb6112 to
05e938c
Compare
adrienaury
approved these changes
Dec 3, 2025
Member
adrienaury
left a comment
adrienaury
left a comment
There was a problem hiding this comment.
OK to publish a "-beta1" version for now
Comment on lines
66
to
106
|
|
||
| committed := make([]Row, 0, commitSize) | ||
|
|
||
| // Handle savepoint on exit | ||
| defer func() { | ||
| if savepointPath != "" { | ||
| if err := savepoint(savepointPath, committed); err != nil { | ||
| log.Error().Msgf("Savepoint failure, %d lines committed unsaved", len(committed)) | ||
| for _, unsaved := range committed { | ||
| if ctx.cfg.SavepointPath != "" { | ||
| if err := savepoint(ctx.cfg.SavepointPath, ctx.committed); err != nil { | ||
| log.Error().Msgf("Savepoint failure, %d lines committed unsaved", len(ctx.committed)) | ||
| for _, unsaved := range ctx.committed { | ||
| log.Warn().Interface("value", unsaved).Msg("Unsaved committed value") | ||
| } | ||
| } | ||
| } | ||
| }() |
Member
There was a problem hiding this comment.
I see commited variable was moved under the ctx execution context.
What happen if the ctx.Run method is called multiple times ? can it create problems because commited var is not cleaned betweens multiples calls ? does it happens ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.