fix: correct host/program alert status placeholders#266
Open
somethingwithproof wants to merge 2 commits intoCacti:developfrom
Open
fix: correct host/program alert status placeholders#266somethingwithproof wants to merge 2 commits intoCacti:developfrom
somethingwithproof wants to merge 2 commits intoCacti:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes invalid SQL generated for host and program alert types in the Syslog plugin by removing an accidental $uniqueID string concatenation from prepared SQL templates, resolving Issue #253.
Changes:
- Remove erroneous
. $uniqueIDconcatenation from thehostalert SQL template. - Remove erroneous
. $uniqueIDconcatenation from theprogramalert SQL template. - Preserve parameter binding (
status = ?with$uniqueIDin$params) to keep prepared statements correct.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
08e7509 to
1137926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/regression/*.phpexistValidation
Fixes #253